[sheepdog] [PATCH 1/2] sheep: fix forward_write_obj_req()

MORITA Kazutaka morita.kazutaka at lab.ntt.co.jp
Thu Jun 7 16:45:22 CEST 2012


At Thu,  7 Jun 2012 17:29:35 +0800,
Liu Yuan wrote:
> 
> From: Liu Yuan <tailai.ly at taobao.com>
> 
> This patch addresses one very sutble problem, to quote from Kazutaka:
> 
> 	One possibility is that if forward_write_obj_req() fails before
> 	receiving data, the next forward_(read|write)_obj_req() could be
> 	interleaved.
> 
> The interleaved requets will return random res->result and sometimes more
> catastrophic, EIO to upper layer and askes the node to leave the cluster.
> 
> Signed-off-by: Liu Yuan <tailai.ly at taobao.com>
> ---
>  sheep/gateway.c |   44 +++++++++++++++++++++-----------------------
>  1 file changed, 21 insertions(+), 23 deletions(-)

Applied, thanks!

I think it's better if the subject describes what problems this patch
fixes briefly.

Kazutaka



More information about the sheepdog mailing list