[sheepdog] [PATCH 2/2] sheep: remove timeout for socket pool

[Liu Yuan]

On 06/07/2012 11:20 PM, Liu Yuan wrote:

> On 06/07/2012 11:07 PM, MORITA Kazutaka wrote:
> 
>> 5 seconds is actually too short, but is it really good to remove
>> timeout completely?  Without timeout, how long does send/recv/poll
>> block when network error happens, and how long do guest OSes wait for
>> read/write/flush to return?
> 
> 
> How about set SO_KEEPALIVE for the connection? Let kernel handle the
> heart-beat message seems to work.
> 


But we already have a membership backend to send heart-beat message to
all nodes, that is why I originally planed to remove timeout completely,
looks to me that we don't actually need any timeout mechanism again.
Previous code need this timeout because IO blocks confchg, but now we
don't have this constraint, so maybe just removing it would be clean and
good enough.

Thanks,
Yuan

> For maximum tolerant timeout, I know 120s for Linux kernel, dunno other
> Kernel's. Or should we set the limit to a value approximate to it, say 110s?
> 
> Maybe the combination of these two?