[sheepdog] [PATCH 1/6] sheep: redesign a new cached sockfd pool

Liu Yuan namei.unix at gmail.com
Mon Jun 25 08:35:58 CEST 2012


On 06/25/2012 01:22 PM, MORITA Kazutaka wrote:
> How about changing this prototype to
> 
>   void sockfd_cache_del(struct sd_node *);
> 
> and avoiding exporting struct node_id?

sheep_del_fd() calls sockfd_cache_del() internally, but sheep_del_fd's
parameter is sd_vnode instead of sd_node. Casting sd_vnode to sd_node
looks weird to me.

Thanks,
Yuan




More information about the sheepdog mailing list