[sheepdog] [PATCH 1/6] sheep: redesign a new cached sockfd pool

Liu Yuan namei.unix at gmail.com
Mon Jun 25 10:11:48 CEST 2012


On 06/25/2012 04:00 PM, MORITA Kazutaka wrote:
> If we allow casting sd_node and sd_vnode to node_id outside
> socketfd_cache.c, it looks cleaner to use node_id for other prototypes
> too:
> 
>   void sockfd_cache_del(struct node_id *);
>   void sockfd_cache_add(struct node_id *);
>   void sockfd_cache_add_group(struct node_id *, int nr);
> 
>   int sheep_get_fd(struct node_id *, int *);
>   void sheep_put_fd(struct node_id *, int fd, int);
>   void sheep_del_fd(struct node_id *, int fd, int);
> 
> I think it's a matter of taste, though.


Yes, actually I have written a patch for that already. I'll send some
clean up patches later when this series is merged.

Thanks,
Yuan



More information about the sheepdog mailing list