[sheepdog] [PATCH v3 6/8] sheep: try best forward_read_obj_req()

[Christoph Hellwig]

On Tue, Jun 26, 2012 at 04:45:42PM +0800, Liu Yuan wrote:
> +			dprintf("remote node might be crashed");

s/be/have/

or better

"remote node might have gone away"

> -			break;
> +			goto reset;
>  		}
> +		sheep_put_fd(v, fd, sock_idx);
> +		memcpy(&req->rp, rsp, sizeof(*rsp));
> +		ret = rsp->result;
> +		if (ret == SD_RES_SUCCESS)
> +			break;
> +reset:

woudldn't and else clause be better readable than the goto inside a loop
here?


Otherwise the patch looks good,

Reviewed-by: Christoph Hellwig <hch at lst.de>