[sheepdog] [PATCH] sheep: reinitialize conn->blocking_siblings after delete it
Liu Yuan
namei.unix at gmail.com
Thu Jun 28 09:05:02 CEST 2012
On 06/28/2012 11:54 AM, Yunkai Zhang wrote:
> if (!list_empty(&ci->conn.blocking_siblings))
I don't think list_empty(entry) is valid check. Looks weird to me,
list_empty() is used to check if list is empty, not entry. It seems that
list.h doesn't provide helper to check if entry is in the list. We
should use other filed to check or provide a new dedicated helper.
Thanks,
Yuan
More information about the sheepdog
mailing list