On 05/17/2012 04:14 PM, Christoph Hellwig wrote: > Assuming some arguments come from sys while the epoch is passed is a bad > convention. In addition the next patch will add a caller that doesn't > take the nodes array from sys. Seems that all the caller of update_epoch_log() pass sys->xxx, so how about refactor it as update_epoch_log(void) ? Thanks, Yuan |