[Sheepdog] [PATCH 3/3] sheep: fix nr_copies in vdi.c

Christoph Hellwig hch at infradead.org
Tue May 1 17:05:18 CEST 2012


On Tue, May 01, 2012 at 09:53:07PM +0800, Liu Yuan wrote:
> I think Levin Li has fixed it already. I'd mention that we(taobao) don't
> run simple store at all. So I'd suggest that if we suspect of something
> wrong, we should firstly try to see if farm has the problem. If not,
> something in simple store would be the culprit.

I don't think that's a sustainable attitude.  There needs to be a
regression test suite catching these kinds of simple bugs for any
combination of backends and cluster drivers easily.

> I'd insist that the best way to respect hdr.copies is to implement that
> feature for real rather than modify it to work with imaginary one.

That's the plan, I just mentioned how to break it in steps.

> What kind of problem to fix?

Kazum mentioned issues in recovery, let him explain it in more detail.



More information about the sheepdog mailing list