[Sheepdog] [PATCH 3/3] sheep: fix nr_copies in vdi.c

Liu Yuan namei.unix at gmail.com
Tue May 1 17:19:33 CEST 2012


On 05/01/2012 11:05 PM, Christoph Hellwig wrote:

>> I think Levin Li has fixed it already. I'd mention that we(taobao) don't
>> > run simple store at all. So I'd suggest that if we suspect of something
>> > wrong, we should firstly try to see if farm has the problem. If not,
>> > something in simple store would be the culprit.
> I don't think that's a sustainable attitude.  There needs to be a
> regression test suite catching these kinds of simple bugs for any
> combination of backends and cluster drivers easily.
> 


I didn't mean it to ignore simple store, perhaps I'd rephrase it better.
I am totally in favor of a test suite to catch these simple bugs and
preferably do regression test and I will mark it as the highest
important feature to be desired.

Thanks,
Yuan



More information about the sheepdog mailing list