[sheepdog] [PATCH v2 2/2] sheep: implement atomic create and write mechanism for config

Liu Yuan namei.unix at gmail.com
Tue Apr 16 08:52:14 CEST 2013


On 04/16/2013 02:39 PM, Hitoshi Mitake wrote:
> sd_iprintf("temporal file for config exists");

It is better rephrased as "remove temporal config file" and this is
nothing interesting for common users, so sd_dprintf() would be better.

> +#define TMP_CONFIG_PATH "/config.tmp"

Add a global pathname isn't necessary because it is can be very easily
deduced from config_path.

Thanks,
Yuan



More information about the sheepdog mailing list