[sheepdog] [PATCH v2 2/2] sheep: implement atomic create and write mechanism for config

Hitoshi Mitake mitake.hitoshi at gmail.com
Tue Apr 16 10:22:26 CEST 2013

At Tue, 16 Apr 2013 14:52:14 +0800,
Liu Yuan wrote:
> On 04/16/2013 02:39 PM, Hitoshi Mitake wrote:
> > sd_iprintf("temporal file for config exists");
> It is better rephrased as "remove temporal config file" and this is
> nothing interesting for common users, so sd_dprintf() would be better.

I agree with the message. But I believe the message should be printed
in the log because it can be a signal of crash and would be useful for
trouble shooting. It is only a one line and written rarely. Printing
with sd_iprintf() produces zero cost realistically.

> > +#define TMP_CONFIG_PATH "/config.tmp"
> Add a global pathname isn't necessary because it is can be very easily
> deduced from config_path.

I agree. I'll fix it in v3.


More information about the sheepdog mailing list