[sheepdog] [PATCH v3 2/2] sheep: implement atomic create and write mechanism for config

Liu Yuan namei.unix at gmail.com
Tue Apr 16 10:42:46 CEST 2013

On 04/16/2013 04:28 PM, Hitoshi Mitake wrote:
> +	snprintf(tmp_config_path, len, "%s" CONFIG_PATH ".tmp", base_path);

Why not remove this tmp_config_path too? We should always use global
variable as less as much. Only write_config() and check_tmp_config()
need it, and both of them can deduce tmp_config_path from config_path,
so I think it is better to get tmp path on the fly instead of a global


More information about the sheepdog mailing list