[sheepdog] [PATCH 5/6] sheep: refactor vdi lookup, create, delete operation

Liu Yuan namei.unix at gmail.com
Wed Apr 24 06:49:30 CEST 2013


On 04/24/2013 11:44 AM, MORITA Kazutaka wrote:
> The comment looks strange to me.  The current VDI must be the right
> side, so we should break here for efficiency even if we don't support
> vdi rollback.

Any suggestion for the comment?

By the way, current VDI isn't an obvious name to indicate it is top vdi
we are currently running (When I firstly came across this name, I have
no idea what it is) . Current working VDI or working VDI for short looks
better, as we have 'working directory' concept, the 'working' is a more
well received name for the currently working object compared to those
objects not in the working(running) state.

Thanks,
Yuan



More information about the sheepdog mailing list