[sheepdog] [PATCH 5/6] sheep: refactor vdi lookup, create, delete operation
MORITA Kazutaka
morita.kazutaka at lab.ntt.co.jp
Wed Apr 24 08:56:53 CEST 2013
At Wed, 24 Apr 2013 12:49:30 +0800,
Liu Yuan wrote:
>
> On 04/24/2013 11:44 AM, MORITA Kazutaka wrote:
> > The comment looks strange to me. The current VDI must be the right
> > side, so we should break here for efficiency even if we don't support
> > vdi rollback.
>
> Any suggestion for the comment?
If the right side is a snapshot vdi, it means that the current vdi is
deleted. How about "Current vdi is deleted"?
>
> By the way, current VDI isn't an obvious name to indicate it is top vdi
> we are currently running (When I firstly came across this name, I have
> no idea what it is) . Current working VDI or working VDI for short looks
> better, as we have 'working directory' concept, the 'working' is a more
> well received name for the currently working object compared to those
> objects not in the working(running) state.
VirtualBox uses 'Current State' for the latest disk image. Anyway,
either is okay to me.
Thanks,
Kazutaka
More information about the sheepdog
mailing list