[sheepdog] [PATCH] sheep: recover uatomic_bool assertions

Liu Yuan namei.unix at gmail.com
Wed Feb 6 06:15:50 CET 2013


On 02/05/2013 11:49 PM, Hitoshi Mitake wrote:
> In the commit 55edb8430f74, the assert() in uatomic_set_false() is
> removed. This patch adds new asserts which share same purpose with the
> removed one to caller side.

I don't think we need this patch because we use assertion only when we
need to exclude possible logic error that is hard to make sure by simply
reading the source code. These code paths are easy to justify the
correctness, so we'd better of by leave it as is.

Thanks,
Yuan



More information about the sheepdog mailing list