[sheepdog] [PATCH] sheep: recover uatomic_bool assertions

[Hitoshi Mitake]

At Wed, 06 Feb 2013 13:15:50 +0800,
Liu Yuan wrote:
> 
> On 02/05/2013 11:49 PM, Hitoshi Mitake wrote:
> > In the commit 55edb8430f74, the assert() in uatomic_set_false() is
> > removed. This patch adds new asserts which share same purpose with the
> > removed one to caller side.
> 
> I don't think we need this patch because we use assertion only when we
> need to exclude possible logic error that is hard to make sure by simply
> reading the source code. These code paths are easy to justify the
> correctness, so we'd better of by leave it as is.

As you say, these code paths are clear so recovered assertions are not
required currently. But sockfd and object cache can be more
complicated in the future. So I thought recovering these assertions
now is worth doing.

Of course, you know far better than me about sockfd and object
cache. If you think this patch makes no sence, let's abandon it.

Thanks,
Hitoshi