[sheepdog] [PATCH] sheep: remove unnecessary extern keyword

MORITA Kazutaka morita.kazutaka at lab.ntt.co.jp
Thu Jan 24 08:18:43 CET 2013


At Thu, 24 Jan 2013 14:49:14 +0800,
Liu Yuan wrote:
> 
> On 01/24/2013 01:08 PM, Liu Yuan wrote:
> > Some prototype use extern but some are not, let's get a consistent nameing.
> 
> Applied.

I'd like you to stop applying patches without review so quickly.

Is removing extern from global variables really correct?.  It means
that the variables are defined in all .c files which include the
header.  Actually, GCC complains the error when the global variables
are initialized.

Thanks,

Kazutaka



More information about the sheepdog mailing list