[sheepdog] [PATCH] sheep: remove unnecessary extern keyword

Liu Yuan namei.unix at gmail.com
Thu Jan 24 08:43:30 CET 2013


On 01/24/2013 03:24 PM, Liu Yuan wrote:
> On 01/24/2013 03:18 PM, MORITA Kazutaka wrote:
>> Is removing extern from global variables really correct?.  It means
>> that the variables are defined in all .c files which include the
>> header.  Actually, GCC complains the error when the global variables
>> are initialized.
> 
> Umm, I used sed to replace all the 'extern' and fixed some warnings, and
> yeah,global variables have this problem. My mistake.
> 

But my GCC (4.6.3) don't complain on the missing extern for global
variables. I guess new GCC might have some magic to handle this
duplicate definition of global variables. Anyway, I've posted a patch to
fix it.

Thanks,
Yuan




More information about the sheepdog mailing list