[sheepdog] [PATCH 2/2] sheep: release object cache when vdi is released

MORITA Kazutaka morita.kazutaka at lab.ntt.co.jp
Tue Jan 29 07:39:07 CET 2013


At Tue, 29 Jan 2013 13:22:06 +0800,
Liu Yuan wrote:
>  
> +static int local_release_vdi(struct request *req)
> +{
> +	uint32_t vid = req->rq.vdi.base_vdi_id;
> +
> +	if (!vid) {
> +		sd_iprintf("Some VDI failed to release the object cache. "
> +			   "Probably you are running old QEMU.\n");
> +		return SD_RES_SUCCESS;
> +	}
> +
> +	object_cache_flush_vdi(vid);
> +	object_cache_delete(vid);

I wonder if sheep should delete cache here.  With this patch, object
cache cannot survive a temporal reboot of the guest os.  Is it
expected behavior?

Thanks,

Kazutaka



More information about the sheepdog mailing list