[sheepdog] [PATCH v3 1/3] logger: format in logger process

Hitoshi Mitake mitake.hitoshi at gmail.com
Wed Jan 30 01:39:28 CET 2013


At Tue, 29 Jan 2013 20:34:48 +0800,
Liu Yuan wrote:
> 
> On 01/29/2013 08:04 PM, Hitoshi Mitake wrote:
> > +static notrace int default_log_format(char *buff, size_t size,
> > +				const struct logmsg *msg)
> 
> This isn't properly aligned. Could you please also add a check to our
> checkpatch to detect such formatting errors?

OK, I'll try it. Correct format is:
return_type function_name(type1 arg1,
                          type2 arg2)

(positions of type[12] are equal)
right?

Thanks,
Hitoshi



More information about the sheepdog mailing list