[sheepdog] [PATCH v3 1/3] logger: format in logger process

[Hitoshi Mitake]

At Wed, 30 Jan 2013 09:52:33 +0800,
Liu Yuan wrote:
> 
> On 01/30/2013 09:41 AM, MORITA Kazutaka wrote:
> > At Tue, 29 Jan 2013 20:34:48 +0800,
> > Liu Yuan wrote:
> >>
> >> On 01/29/2013 08:04 PM, Hitoshi Mitake wrote:
> >>> +static notrace int default_log_format(char *buff, size_t size,
> >>> +				const struct logmsg *msg)
> >>
> >> This isn't properly aligned. Could you please also add a check to our
> >> checkpatch to detect such formatting errors?
> > 
> > What do you think proper indentation is?  Seems that emacs indents the
> > code as Hitoshi wrote if we use an example of .emacs in
> > http://www.kernel.org/doc/Documentation/CodingStyle
> > 
> 
> As Hitoshi said, I think parameters should be equally aligned as other
> functions in the sheepdog.
> 
> ret_type function_name(para1, para2
>                        para3)
> {
>    ....
> }
> I don't use emacs, but I think there is some options to do it. For vim,
> we can add these settings in .vimrc to achieve this:
> =====
> set cindent
> set cino=:0,(0,t0
> =====
> 
> Well it seems this is affected by how long tap take whilespace... I
> changed tabstop=8, then it is not equally aligned. So it is okay to not
> align it.
> 

OK, let's leave the coding style as it is.
Do you have any other opinions on the logger patchset?

Thanks,
Hitoshi