[sheepdog] cluster_recovery_completion function bug

王帆 wangfan1985 at gmail.com
Fri Mar 15 07:48:25 CET 2013


in the cluster_recovery_completion function,i think
memcmp(vnode_info->nodes, recovereds,sizeof(*recovereds) *
nr_recovereds) == 0 line have a bug.
beceuse the Function parameter vnode_info->nodes and recovereds will have
different nr_vnodes number after recovery completion.vnode_info->nodes of
nr_vnodes variable calculated by recalculate_vnodes function.In my
environment it is 61 and 67.
and recovereds of nr_vnodes variable is a fixed value.It is usually 64.
in this case sd_store->cleanup() will not be executed.

for example.If the the node1 disk size is 1G,node2 is 2G node3 is 3G.
sd_store->cleanup()
will not be executed forever.


Thanks
Fan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wpkg.org/pipermail/sheepdog/attachments/20130315/b165ed8d/attachment-0003.html>


More information about the sheepdog mailing list