[sheepdog] [PATCH v5 13/16] collie/farm: implement farm

Liu Yuan namei.unix at gmail.com
Mon May 20 14:52:57 CEST 2013


On 05/20/2013 03:50 PM, Kai Zhang wrote:
> +	for (i = 0; i < nr_trunks; i++, trunk_entry++) {
> +		struct sha1_file_hdr hdr;
>  		void *buffer = NULL;

It would be nicer to add a helper such as

 for_each_object_in_trunk()

here to simplify the code structure.

Thanks,
Yuan



More information about the sheepdog mailing list