[sheepdog] [PATCH v5 13/16] collie/farm: implement farm

Liu Yuan namei.unix at gmail.com
Mon May 20 15:24:32 CEST 2013


On 05/20/2013 03:50 PM, Kai Zhang wrote:
> +	/* fill sha1 file */
> +	memcpy(hdr.tag, TAG_DATA, TAG_LEN);
> +	hdr.size = size;
> +
> +	/* fill obj_strbuf */
> +	strbuf_add(&obj_strbuf, buf, size);
> +	strbuf_insert(&obj_strbuf, 0, &hdr, sizeof(hdr));
> +
> +	/* write sha1 file and fill trunk entry */

These three comments look unnecessary to me because it doesn't make the
thing clearer.

Thanks,
Yuan



More information about the sheepdog mailing list