[sheepdog] [PATCH v2 04/11] sheep: don't check nodes information for joined nodes

Hitoshi Mitake mitake.hitoshi at gmail.com
Tue Sep 17 18:42:40 CEST 2013


At Sat, 14 Sep 2013 18:34:24 +0800,
Liu Yuan wrote:
> 
> cluster_join_check is basically used to check newly joining node. But the old
> code also check the nodes states passed by cinfo with sys->cinfo. After we have
> struct rb_node rb in the sd_node, we'll never have this check passed.
> 
> Instead of doing the check with more complex code, this patch simply remove the
> check since nodes states in the joined nodes are always the same.

If these states are always identical, we can eliminate
cluster_info_copy(&sys->cinfo, cinfo); in sd_accept_handler().

I think eliminating the check is correct, but the actual reason is
that the check isn't meaningful in the current code. The commit log
isn't correct.

Thanks,
Hitoshi



More information about the sheepdog mailing list