[sheepdog] [PATCH v2 02/11] sheep: remove local_idx in struct sd_rsp
MORITA Kazutaka
morita.kazutaka at gmail.com
Wed Sep 18 19:37:58 CEST 2013
At Sat, 14 Sep 2013 18:34:22 +0800,
Liu Yuan wrote:
>
> This field is never used and since it is used internally by dog and sheep, it is
> safe to remove it completely from the structure as we currently always have dog
> and sheep out of the same repo.
>
> Signed-off-by: Liu Yuan <namei.unix at gmail.com>
> ---
> include/sheepdog_proto.h | 1 -
> sheep/group.c | 2 --
> 2 files changed, 3 deletions(-)
>
> diff --git a/include/sheepdog_proto.h b/include/sheepdog_proto.h
> index b1a621b..fbfaa5a 100644
> --- a/include/sheepdog_proto.h
> +++ b/include/sheepdog_proto.h
> @@ -181,7 +181,6 @@ struct sd_rsp {
> struct {
> uint32_t __pad;
> uint32_t nr_nodes;
> - uint32_t local_idx;
> uint32_t __reserved;
> uint64_t store_size;
> uint64_t store_free;
This breaks 64 bit alignment. Please make __reserved uint64_t.
Thanks,
Kazutaka
More information about the sheepdog
mailing list