[sheepdog] [PATCH] remove trim/untrim functions

MORITA Kazutaka morita.kazutaka at gmail.com
Tue Sep 24 03:02:23 CEST 2013


At Thu, 19 Sep 2013 20:05:44 +0800,
Liu Yuan wrote:
> 
> Why?
> 1. it makes code very complicated because trim/untrim is scattered everywhere in
> the code
> 2 it is hard to pass correct parameters to them
> 3. only deleted inode can benefit from it for the recovery code, but deleted
> inodes are relatively small group compared to data objects
> 
> We need a more lower level and transparent mechanism to reduce io network
> because sheepdog data management shouldn't be aware of it thus greatly simplify
> the code for read.
> 
> Signed-off-by: Liu Yuan <namei.unix at gmail.com>
> ---
>  - this is on top of erasure code path and with it, erasure code can work
>    without any problems.
> 
>  dog/common.c    |    2 --
>  dog/vdi.c       |    5 -----
>  sheep/gateway.c |    8 --------
>  sheep/ops.c     |   16 +---------------
>  sheep/store.c   |    4 ----
>  5 files changed, 1 insertion(+), 34 deletions(-)

Applied, thanks.

Kazutaka



More information about the sheepdog mailing list