[sheepdog] [PATCH] fix systemd support on CentOS/RHEL 7

Hitoshi Mitake mitake.hitoshi at lab.ntt.co.jp
Wed Nov 26 10:12:16 CET 2014


Hi Vladislav, thanks a lot for posting your patch.

But I have to point 2 style problems (not essential).
-  You have to add Signed-off-by line to your patch. In your case, it
   would be:
   Signed-off-by Vladislav Gorbunov <vadikgo at gmail.com>
-  Your patch seems to be ill-formed. Did you used git send-email
   command? Sending patch from mailer would break the style of your
   patch.

I'm cc-ing Vasiliy, the original creator of systemd config
file. Vasiliy, could you review the content of the below change?

Thanks,
Hitoshi

At Wed, 26 Nov 2014 20:49:18 +1200,
Vladislav Gorbunov wrote:
> 
> [1  <multipart/alternative (7bit)>]
> [1.1  <text/plain; UTF-8 (7bit)>]
> diff --git a/script/sheepdog.service.in b/script/sheepdog.service.in
> index 555083e..0e5aa56 100644
> --- a/script/sheepdog.service.in
> +++ b/script/sheepdog.service.in
> @@ -7,7 +7,7 @@ Wants=syslog.target
>  EnvironmentFile=- at SYSCONFDIR@/conf.d/sheepdog.conf
>  EnvironmentFile=- at SYSCONFDIR@/sysconfig/sheepdog
>  EnvironmentFile=- at SYSCONFDIR@/default/sheepdog
> -ExecStart=@SBINDIR@/sheep --pidfile @LOCALSTATEDIR@/run/sheep.pid
> ${SHEEP_OPTS:-"--cluster local --log syslog --pidfile
> @LOCALSTATEDIR@/run/sheep.pid --upgrade @LOCALSTATEDIR@/lib/sheepdog"}
> +ExecStart=@SBINDIR@/sheep --pidfile @LOCALSTATEDIR@/run/sheep.pid
> --log dst=syslog $SHEEP_OPTS @LOCALSTATEDIR@/lib/sheepdog
>  PIDFile=@LOCALSTATEDIR@/run/sheep.pid
>  Type=forking
> [1.2  <text/html; UTF-8 (quoted-printable)>]
> 
> [2  <text/plain; us-ascii (7bit)>]
> -- 
> sheepdog mailing list
> sheepdog at lists.wpkg.org
> http://lists.wpkg.org/mailman/listinfo/sheepdog



More information about the sheepdog mailing list