[sheepdog] [PATCH] fix systemd support on CentOS/RHEL 7

Vasiliy Tolstov v.tolstov at selfip.ru
Wed Nov 26 10:17:03 CET 2014


2014-11-26 12:12 GMT+03:00 Hitoshi Mitake <mitake.hitoshi at lab.ntt.co.jp>:
> Hi Vladislav, thanks a lot for posting your patch.
>
> But I have to point 2 style problems (not essential).
> -  You have to add Signed-off-by line to your patch. In your case, it
>    would be:
>    Signed-off-by Vladislav Gorbunov <vadikgo at gmail.com>
> -  Your patch seems to be ill-formed. Did you used git send-email
>    command? Sending patch from mailer would break the style of your
>    patch.
>
> I'm cc-ing Vasiliy, the original creator of systemd config
> file. Vasiliy, could you review the content of the below change?


Hello. Vladislav,  what you change with this patch? As you see in case
of specify SHEEP_OPTS you can override all needed variables. Defaults
as i think have safe values and not break anything.

-- 
Vasiliy Tolstov,
e-mail: v.tolstov at selfip.ru
jabber: vase at selfip.ru



More information about the sheepdog mailing list