[sheepdog] [PATCH v1] fix systemd service to run sheep in foreground and with defaults

[Alexander Guy]

On Wed, Apr 08, 2015 at 09:27:50AM +0300, Vasiliy Tolstov wrote:
> 2015-04-08 9:22 GMT+03:00 Liu Yuan <namei.unix at gmail.com>:
> > I am no guru of systemd but I noticed '--cluster local'. Does it mean we run
> > sheep by local driver for default setup? Local driver is basically for testing
> > for a single node cluster, in which sense, it would be bad idea to make local
> > driver as default, because most people want to run multi-node sheepdog cluster.
> 
> 
> Multi node cluster need additional setup, so user know how to install
> zookeeper or corosync, so user can override defaults via
> config file. This defaults  for user that install sheepdog and run it
> in single node to check.
> So this is sane defaults to immediately run sheepdog without additional config.

Vasiliy,
   This isn't how this should be done: the systemd service file shouldn't
be sheepdog's configuration file.  By requiring that administrators edit the
service when they want to configure sheepdog you:

    - break existing package checksum tools, unless they have an explicit override.
    - break existing installs that already expect to have their configuration in /etc.

If you want to have sane defaults, install them in a file in /etc
(e.g. /etc/default/sheepdog) and leave the systemd service file as minimal
as possible.

Thanks.


Alexander