[sheepdog] [PATCH v1] fix systemd service to run sheep in foreground and with defaults

Vasiliy Tolstov v.tolstov at selfip.ru
Fri Apr 10 00:36:58 CEST 2015


2015-04-09 20:08 GMT+03:00 Alexander Guy <alexander at andern.org>:
> Vasiliy,
>    This isn't how this should be done: the systemd service file shouldn't
> be sheepdog's configuration file.  By requiring that administrators edit the
> service when they want to configure sheepdog you:
>
>     - break existing package checksum tools, unless they have an explicit override.
>     - break existing installs that already expect to have their configuration in /etc.
>

If you install file in /etc this is override systemd service file
defaults where the problem? Environment variable overrides by three
files.
Please re-read docs about systemd, you don't need to modify systemd
service file, only puts config in /etc/ dir.

> If you want to have sane defaults, install them in a file in /etc
> (e.g. /etc/default/sheepdog) and leave the systemd service file as minimal
> as possible.




-- 
Vasiliy Tolstov,
e-mail: v.tolstov at selfip.ru
jabber: vase at selfip.ru



More information about the sheepdog mailing list