[sheepdog] [PATCH v1] fix systemd service to run sheep in foreground and with defaults

[Alexander Guy]

On Fri, Apr 10, 2015 at 01:36:58AM +0300, Vasiliy Tolstov wrote:
> 
> If you install file in /etc this is override systemd service file
> defaults where the problem? Environment variable overrides by three
> files.

Vasiliy,
    Ah, no, sorry: I misread your patch.  For some reason I thought you were removing the existing EnvironmentFiles.

That said:

> +Environment="DAEMON_ARGS=--cluster local --log dst=syslog -f --upgrade" "SHEEPDOG_PATH=@LOCALSTATEDIR@/lib/sheepdog"
> -ExecStart=/bin/sh -c 'ulimit -n 32768; @SBINDIR@/sheep --pidfile @LOCALSTATEDIR@/run/sheep.pid $(if [ -z "$SHEEP_OPTS" ]; then echo "--cluster local --log dst=syslog --upgrade @LOCALSTATEDIR@/lib/sheepdog"; else echo $SHEEP_OPTS; fi)'

Existing (non-Debian) installs using this service file are expecting SHEEP_OPTS, but now you're changing environment variables to DAEMON_ARGS and SHEEPDOG_PATH.

Isn't this going to break existing configurations?

> +ExecStart=/usr/sbin/sheep $DAEMON_ARGS $SHEEPDOG_PATH

This should probably be @SBINDIR@/sheep.

> +LimitNOFILE=830000

Isn't this redundant given the recent setrlimit changes?

Thanks.


Alexander