[sheepdog] [PATCH v1] fix systemd service to run sheep in foreground and with defaults

Vasiliy Tolstov v.tolstov at selfip.ru
Fri Apr 10 18:33:09 CEST 2015


2015-04-10 6:18 GMT+03:00 Alexander Guy <alexander at andern.org>:
> Existing (non-Debian) installs using this service file are expecting SHEEP_OPTS, but now you're changing environment variables to DAEMON_ARGS and SHEEPDOG_PATH.
>
> Isn't this going to break existing configurations?
>
>> +ExecStart=/usr/sbin/sheep $DAEMON_ARGS $SHEEPDOG_PATH
>

we can make compromiss with debian ubuntu and fedora and use same
variables.. what do you think?

> This should probably be @SBINDIR@/sheep.
>
thanks

>> +LimitNOFILE=830000
>
> Isn't this redundant given the recent setrlimit changes?

Yes, but why not =)


-- 
Vasiliy Tolstov,
e-mail: v.tolstov at selfip.ru
jabber: vase at selfip.ru



More information about the sheepdog mailing list