[Stgt-devel] [Patch1/2] Add-new-module-entry-points-for-configuration

[FUJITA Tomonori]

From: "Mark Harvey" <markh794 at gmail.com>
Subject: Re: [Stgt-devel] [Patch1/2]	Add-new-module-entry-points-for-configuration
Date: Sat, 2 Jun 2007 13:31:14 +1000

> > Well, why does the second patch need this change?
> >
> 
> spc.c contains :
> 
> enum {
>         Opt_scsiid, Opt_scsisn,
>         Opt_VendorIdent, Opt_ProductIdent,
>         Opt_ProductRev, Opt_SenseFormat,
>         Opt_Removable, Opt_Online,
>         Opt_err,
> };
> 
> So at the moment,
> enum {MAX_OPT_ARGS = 17};
> should read:
> enum {MAX_OPT_ARGS = 9};
> 
> 
> Once I get these current patches up to scratch and move on the the SMC
> module, the extra 8 options (or maybe more) will be needed.
> 
> parser.c checks for MAX_OPT_ARGS in several places.
> 
> It would be nice to have this size set either at run time or uniq to
> each scsi module.
> i.e. spc only requires the above 9, the smc module will require about 17.

Have you tried your code without touching MAX_OPT_ARGS?