On Mon, 06 Oct 2008 16:36:31 +0200 Tomasz Chmielewski <mangoo at wpkg.org> wrote: > Doron Shoham schrieb: > > Hi, > > > > In some tgtadm commands we don't use --lld option (e.g show command) > > so when using a different driver (e.g fcoe) the command fails. > > > > I think we should always use the --lld for tgtadm commands. > > (this apply for delete, update, etc...) > > What do you think? > > These are the command where we don't add --lld: > > # grep \"tgtadm tgt-admin|grep -v lld > > execute("tgtadm --op show --mode target"); > execute("tgtadm --op update --mode target --tid=$tgtadm_output_tid{$existing_target} -n state -v $var"); > execute("tgtadm --op update --mode target --tid=$1 -n state -v $var"); > execute("tgtadm --op update --mode target --tid=$tgtadm_output_tid{$off_ready} --name=\"$off_ready\" -n state -v $var"); > execute("tgtadm --op unbind --mode target --tid $tgtadm_output_tid{$current_target} -I $acl"); > execute("tgtadm --op delete --mode conn --tid $tgtadm_output_tid{$current_target} --sid $sid --cid $cid"); > execute("tgtadm --mode target --op delete --tid=$tgtadm_output_tid{$current_target}"); > execute("tgtadm --mode target --op delete --tid=$tgtadm_output_tid{$current_target}"); > > > Surely we can add --lld, provided it won't break anything ;) IIRC, tgtadm always require the lld option (if the lld option is not provided, tgtadm uses the first lld for convenience). So I think that it's better to always use the lld option in tgt-admin. -- To unsubscribe from this list: send the line "unsubscribe stgt" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html |