[stgt] setting write cache fails in recent git

[FUJITA Tomonori]

On Thu, 16 Oct 2008 10:35:29 +0200
Tomasz Chmielewski <mangoo at wpkg.org> wrote:

> In recent git, setting write cache to off fails:
> 
> # tgtadm --lld iscsi --op update --mode logicalunit --tid 2 --lun=1 --params mode_page=8:0:18:0x10:0:0xff:0xff:0:0:0xff:0xff:0xff:0xff:0x80:0x14:0:0:0:0:0:0
> tgtadm: option 5 not supported in logicalunit mode
> 
> 
> I checked the git from 2008-10-16 and 2008-10-15.
> 
> It works fine (i.e., I'm able to disable write cache) in git fetched on 2008-10-13.

I think that this fixes the update operations in the logicalunit mode
though there might be other regressions about the tgtadm.


diff --git a/usr/tgtadm.c b/usr/tgtadm.c
index 2169c86..06f18e2 100644
--- a/usr/tgtadm.c
+++ b/usr/tgtadm.c
@@ -666,6 +666,14 @@ int main(int argc, char **argv)
 				exit(EINVAL);
 			}
 			break;
+		case OP_UPDATE:
+			rc = verify_mode_params(argc, argv, "LmotlP");
+			if (rc) {
+				eprintf("option '-%c' not supported in "
+					"logicalunit mode\n", rc);
+				exit(EINVAL);
+			}
+			break;
 		default:
 			eprintf("option %d not supported in "
 					"logicalunit mode\n", op);
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html