[stgt] setting write cache fails in recent git

Doron Shoham dorons at Voltaire.COM
Sun Oct 19 09:49:32 CEST 2008


>>
>> Signed-off-by: root <root at debiancloner.voltaire.com>
> 
> Are you sure about this Signed-off-by?

Of course, my mistake.
> 
> 
>> ---
>>  usr/tgtadm.c |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/usr/tgtadm.c b/usr/tgtadm.c
>> index 06f18e2..c9a3d74 100644
>> --- a/usr/tgtadm.c
>> +++ b/usr/tgtadm.c
>> @@ -140,7 +140,7 @@ Linux SCSI Target Framework Administration Utility.\n\
>>                          enable the target to accept the specific initiators.\n\
>>    --lld [driver] --mode target --op unbind --tid=[id] --initiator-address=[src]\n\
>>                          disable the specific permitted initiators.\n\
>> -  --lld [driver] --mode logicalunit --op new --tid=[id] --lun=[lun] --backing-store=[path]\n\
>> +  --lld [driver] --mode logicalunit --op new --tid=[id] --lun=[lun] --backing-store=[path] --bstype=[type]\n\
> 
> Well, bstype is optional. I think that we need to make it clear here.
> 

enable bstype option when creating a new logicalunit

Signed-off-by: Doron Shoham <dorons at voltaire.com>
---
 usr/tgtadm.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/usr/tgtadm.c b/usr/tgtadm.c
index 06f18e2..6e1c61b 100644
--- a/usr/tgtadm.c
+++ b/usr/tgtadm.c
@@ -140,11 +140,12 @@ Linux SCSI Target Framework Administration Utility.\n\
                         enable the target to accept the specific initiators.\n\
   --lld [driver] --mode target --op unbind --tid=[id] --initiator-address=[src]\n\
                         disable the specific permitted initiators.\n\
-  --lld [driver] --mode logicalunit --op new --tid=[id] --lun=[lun] --backing-store=[path]\n\
+  --lld [driver] --mode logicalunit --op new --tid=[id] --lun=[lun] --backing-store=[path] --bstype=[type]\n\
                         add a new logical unit with [lun] to the specific\n\
                         target with [id]. The logical unit is offered\n\
                         to the initiators. [path] must be block device files\n\
                         (including LVM and RAID devices) or regular files.\n\
+                        bstype is optional (default is 'rdwr').\n\
   --lld [driver] --mode logicalunit --op delete --tid=[id] --lun=[lun]\n\
                         delete the specific logical unit with [lun] that\n\
                         the target with [id] has.\n\
@@ -646,7 +647,7 @@ int main(int argc, char **argv)
 		}
 		switch (op) {
 		case OP_NEW:
-			rc = verify_mode_params(argc, argv, "Lmotlb");
+			rc = verify_mode_params(argc, argv, "LmotlbE");
 			if (rc) {
 				eprintf("target mode: option '-%c' is not "
 					  "allowed/supported\n", rc);
-- 
1.5.3.8

--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



More information about the stgt mailing list