[wpkg-users] adobe 8 to adobe 9 upgrade

[Brian May]

Hello,

I have noticed this upgrade process is kind of weird. Initially the 
removal of adobereader8 failed, so it installed adobereader9 and then 
reinstalled adobereader8. So I removed the install and upgrade lines 
from adobereader8 to prevent this happening again.

Anyway the first run:

2008-10-17 09:36:56, INFO   : Removing Acrobat Reader8 (adobereader8)...
2008-10-17 09:36:56, DEBUG  : Executing command: MsiExec.exe /q 
/x{AC76BA86-7AD7-1033-7B44-A80000000002}
2008-10-17 09:37:05, DEBUG  : Command returned result: 1605
2008-10-17 09:37:05, ERROR  : Exit code returned non-successful value: 
1605|Package: Acrobat Reader8.|Command:|MsiExec.exe /q 
/x{AC76BA86-7AD7-1033-7B44-A80000000002}
2008-10-17 09:37:05, DEBUG  : Checking existence of package: Acrobat Reader8
2008-10-17 09:37:05, DEBUG  : Uninstall entry for Adobe Reader 8.1.2 was 
found: test successful
2008-10-17 09:37:05, DEBUG  : Checking adobereader8 zombie state.
2008-10-17 09:37:05, ERROR  : Could not process (remove) Acrobat 
Reader8.|Package still installed.
[...]
2008-10-17 09:37:33, DEBUG  : Fetched 1 install command(s).
2008-10-17 09:37:33, DEBUG  : Executing command : msiexec /q /i 
"%SOFTWARE%\adobereader\9.0.0\AcroRead.msi" allusers=1
2008-10-17 09:39:23, INFO   : Command 'msiexec /q /i 
"%SOFTWARE%\adobereader\9.0.0\AcroRead.msi" allusers=1 returned non-zero 
exit code [0]. This exit code is not an error.
2008-10-17 09:39:23, INFO   : Command in installation of Acrobat Reader9 
returned exit code [0]. This exit code indicates success.
2008-10-17 09:39:23, DEBUG  : Checking existence of package: Acrobat Reader9
2008-10-17 09:39:23, DEBUG  : Uninstall entry for Adobe Reader 9 was 
found: test successful
2008-10-17 09:39:23, DEBUG  : Adding settings node: 'Acrobat Reader9' 
(adobereader), Revision 1
2008-10-17 09:39:23, INFO   : Processing (install) of Acrobat Reader9 
successful.
2008-10-17 09:39:23, DEBUG  : Restoring previous environment.


On the second run:

2008-10-17 09:40:29, DEBUG  : Install type: install
2008-10-17 09:40:29, DEBUG  : Fetched 0 install command(s).
2008-10-17 09:40:29, DEBUG  : Checking existence of package: Acrobat Reader8
2008-10-17 09:40:29, DEBUG  : Uninstall entry for Adobe Reader 8.1.2 
missing: test failed
2008-10-17 09:40:29, ERROR  : Could not process (install) Acrobat 
Reader8.|Failed checking after installation.
2008-10-17 09:40:29, DEBUG  : Restoring previous environment.
2008-10-17 09:40:29, INFO   : Removing Acrobat Reader8 (adobereader8)...
2008-10-17 09:40:29, DEBUG  : Executing command: MsiExec.exe /q 
/x{AC76BA86-7AD7-1033-7B44-A80000000002}
2008-10-17 09:40:39, DEBUG  : Command returned result: 1605
2008-10-17 09:40:39, ERROR  : Exit code returned non-successful value: 
1605|Package: Acrobat Reader8.|Command:|MsiExec.exe /q 
/x{AC76BA86-7AD7-1033-7B44-A80000000002}
2008-10-17 09:40:39, DEBUG  : Checking existence of package: Acrobat Reader8
2008-10-17 09:40:39, DEBUG  : Uninstall entry for Adobe Reader 8.1.2 
missing: test failed
2008-10-17 09:40:39, INFO   : Removal of 'Acrobat Reader8 successful.

[...]

2008-10-17 09:40:39, DEBUG  : Package 'Acrobat Reader9' (adobereader): 
Not yet processed during this session.
2008-10-17 09:40:39, DEBUG  : Checking existence of package: Acrobat Reader9
2008-10-17 09:40:39, DEBUG  : Uninstall entry for Adobe Reader 9 was 
found: test successful
2008-10-17 09:40:39, DEBUG  : Package 'Acrobat Reader9' (adobereader): 
Already installed. Skipping.



I suspect what is happening is that the uninstall code 
AC76BA86-7AD7-1033-7B44-A80000000002 - which I copied from the wiki - 
seems to be wrong - on my systems it is: 
AC76BA86-7AD7-1033-7B44-A81200000003


wpkg then installed the adobereader9 package which automatically removes 
the older package.

On the next reboot wpkg gets confused because adobereader8 is still 
marked as installed, but isn't, so it reinstalls it (at least until I 
commented that line out - I think that is what the message is saying), 
and then tries to remove it, which fails because the code is still 
wrong. It then detects that adobereader8 is still installed because it 
just reinstalled it (unless I removed this line).

It kind of surprised me that wpkg tried to install the package again 
after it was removed and it was still marked for removal.


When I changed the product code as above, it seems to work a lot better.


As a side note, I don't like the practise of appending the version 
number on the package id (like suggested in the wiki) - it means 
upgrades are treated as remove+install, so I changed it to just adobereader.


Brian May