[wpkg-users] [Bug 170] An "uninstall" type check with version comparison succeeds if the uninstall entry is missing

[bugzilla-daemon at bugzilla.wpkg.org]

http://bugzilla.wpkg.org/show_bug.cgi?id=170


Rainer Meier <r.meier at wpkg.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |r.meier at wpkg.org




--- Comment #1 from Rainer Meier <r.meier at wpkg.org>  2009-08-10 20:23:47 ---
Hi Malte,

Did you verify the behavior you're describing here? Actually the following code
can be found right above:

var uninstallValue = getRegistryValue(uninstallLocations[iUninstKey] +
"\\DisplayVersion");

dinfo("Found version of '" + checkPath + "' at " +
uninstallLocations[iUninstKey] +
    ": " + uninstallValue + "\n" + "Comparing to expected version: " +
checkValue);

// check if valid version value was returned
if (uninstallValue == null || uninstallValue == "") {
    error("Check condition '" + checkCond + "' cannot be executed" +
        " since no version information is available for '" + checkPath + "'" +
        " at " + uninstallLocations[iUninstKey]);
    return false;
}


To explain:
If WPKG encounters the case that there is no version information in the
uninstall information or the version string is empty it prints an error message
and returns false - this means the check failed.

So I expect WPKG to return a failed check in case you use
"versiongreaterorequal" in uninstall checks and the uninstall entry does not
exist at all. Including an error logged.

I did not verify yet since I don't have time for it today.

br,
Rainer

-- 
Configure bugmail: http://bugzilla.wpkg.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.