[wpkg-users] wpkg uninstall check subkey in registry

[Rainer Meier]

Hi,

> On Mon, Jun 14, 2010 at 10:44 AM, Pendl Stefan
> <stefan.pendl at haidlmair.at <mailto:stefan.pendl at haidlmair.at>> wrote:
> 
>     Hi Rainer,
> 
>     I think the check for the sub-keys is adding a huge delay to the
>     whole process.
> 
>     With RC3 checking over 100 packages was done in a glimpse, but now
>     it takes ages.
> 
>     I would recommend a setting to turn it on or off, or even better to
>     create a check attribute for the sub-key-level-depth.

Well, during testing I did not really notice this problem since my test system
does not have so many uninstall entries. It seems like querying the registry for
each of these uninstall keys takes very long time.
Not sure if it could be improved. So I've disabled the recursive support again
for now. But I left the code to support recursive reading untouched, so it can
be used for other things in the future.

I don't think it makes sense to put a switch to enable/disable it. There are
very rare cases where such sub-keys in the uninstall key are written. Windows
does not even seem to support it. And you cannot enable/disable it on
per-package base so either it's enabled or disabled and I doubt somebody would
accept such a huge slow-down just if a single package needs it for convenient
uninstall checks. One would rather go for a registry or file check instead.



On 14.06.2010 19:37, Troy Hamilton wrote:
> Since the sub-key uninstall entries don't show up in "Add or Remove
> Programs" list (thus they are not true "uninstall" checks) should they
> be treated the same as any other "registry" check so as to avoid the delay?
> 
> It appears that this must really be an edge case if it has never come up
> before now.

I fully agree. Maybe it's much better here to specify a registry check on the
uninstall entry instead of having WPKG hunt for such a key in non-supported
sub-keys.

I've disabled recursive parsing of uninstall entries again now but I left the
code untouched so we can re-use it for other registry keys if needed.


br,
Rainer