[wpkg-users] [BUG?] On upgrade old check condition are parsed...

[Marco Gaiarin]

I've hit a VLC installer bug of version 1.1.0, on (un)install simply the
installer crash and delete the uninstall.exe binary.
Subsequent execution of the recipe simply stall.

So i've complicated the check condition looking also at the
uninstaller:

        <check type="logical" condition="and">
                <check type="uninstall" condition="exists" path="VLC media player 1.1.4" />
                <check type="file" condition="exists" path='%ProgramFiles%\VideoLAN\VLC\uninstall.exe' />
        </check>

and added to the install action some brute-force:

        <install cmd='%COMSPEC% /c if exist "%ProgramFiles%\VideoLAN\VLC\uninstall.exe" start "" /wait "%ProgramFiles%\VideoLAN\VLC\uninstall.exe" /S _?=%ProgramFiles%\VideoLAN\VLC' />
        <install cmd='%COMSPEC% /c if not exist "%ProgramFiles%\VideoLAN\VLC\uninstall.exe" if exist "%ProgramFiles%\VideoLAN\VLC\vlc.exe" rd /q /s "%ProgramFiles%\VideoLAN"' />
        <install cmd='reg delete "HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\VLC media player" /va /f' />
        <install cmd='"%SOFTWARE%\WPKG\vlc-1.1.4-win32.exe" /S' />

But i've discovered that anyway the ''upgrade'' actions are executed,
even if the new check condition are false for a ''broken'' vlc
installation.

Seems to me that WPKG evaluate on upgrade the old check condition, and
not the new one (or better: evaluate on pre-action the old one, and on
post-action the new one).


I've tried to consider this a feature, but still seems to me a bug. ;-)

Thanks.

-- 
dott. Marco Gaiarin				    GNUPG Key ID: 240A3D66
  Associazione ``La Nostra Famiglia''                http://www.sv.lnf.it/
  Polo FVG  -  Via della Bontà, 7 - 33078  -  San Vito al Tagliamento (PN)
  marco.gaiarin(at)sv.lnf.it	  tel +39-0434-842711  fax +39-0434-842797

		Dona il 5 PER MILLE a LA NOSTRA FAMIGLIA!
	   http://www.lanostrafamiglia.it/chi_siamo/5xmille.php
	(cf 00307430132, categoria ONLUS oppure RICERCA SANITARIA)