[wpkg-users] [BUG?] On upgrade old check condition are parsed...

[Rainer Meier]

Hi Marco,

On 26.11.2010 11:54, Marco Gaiarin wrote:
> Mandi! Rainer Meier
>   In chel di` si favelave...
> 
>> Sure it would. For most users upgrades would be completely skipped all the time
>> if WPKG would first use the checks before installation and if they succeed skip
>> the update. Most packages simply use a check on uninstall entries which
> 
> No, i don't think at skipping upgrades, but:
> 
> if (revision changed) {
> 	if (check condition = true)	# so package installed
> 		do_upgrade()
> 	else				# so package not installed
> 		do_install()		# using new recipe install command
> }

This is an interesting approach.
If the revision of the package is changed, then the package has for sure been
installed using WPKG before. So this additional check would impose a change only
in the case that during upgrade WPKG finds that the local package has been
removed meanwhile.
Well, very rare case but I think this should not break anything.

But remember that in 99.xxx% of the cases WPKG would run on the machine before
and then (revision not changed) detect a broken check condition and re-install
the package (install commands executed).

So yes, under this perspective I think it would be consistent that WPKG executes
the install command. Remember that WPKG would also here have to use the checks
of the locally installed package to verify whether the package is installed.


> This indeed does not cure my ''vlc problem'' (because clearly the
> current check condition have to be evaluated, not the new one...) but
> permit me to write (at least for me ;) simple recipes.

I will have a look if the approach above can be implemented. So before
performing an upgrade WPKG would check whether the package is still installed.

But as I said in most cases you will have many /synchronize runs before where
WPKG would anyway run the install commands (defined in local package) again if
the package is found to be lost locally.

br,
Rainer