[wpkg-users] Disable download switch and config options

[Marco Gaiarin]

> Probably i can simply put the 'download' tag, but clients will probably
> throw errors (they have no write access on %SOFTWARE%).

More dig in this issue. I need that. ;-)

I've tried to put the 'download' tag, but as supposed they throw an
access permission error, even if really works. Look at:

1) download do their job, but throw an error:

 2011-05-16 11:22:57, DEBUG   : Install type: upgrade
 2011-05-16 11:22:57, DEBUG   : Fetched 1 upgrade command(s).
 2011-05-16 11:22:57, DEBUG   : Downloading 'http://www.piriform.com/ccleaner/download/slim/downloadfile' to '\\MEDIA\Software\WPKG\ccsetup306_slim.exe'
 2011-05-16 11:23:13, ERROR   : Download failed: Autorizzazione negata
 2011-05-16 11:23:13, ERROR   : Failed to download all files.

2) wpkg.js anyway ignore this failure, and continue processing:

 2011-05-16 11:23:13, DEBUG   : Executing command: "%SOFTWARE%\WPKG\ccsetup306_slim.exe" /S /L=1040
 2011-05-16 11:23:15, DEBUG   : Command in installation of CCleaner returned exit code [0]. Success.
 2011-05-16 11:23:15, DEBUG   : Checking existence of package: CCleaner
 2011-05-16 11:23:15, DEBUG   : Saving current environment
 2011-05-16 11:23:15, DEBUG   : Reading variables from package CCleaner
 2011-05-16 11:23:15, DEBUG   : Reading variables from profile[s]
 2011-05-16 11:23:15, DEBUG   : Getting profiles which apply to this node.
 2011-05-16 11:23:15, DEBUG   : 3 profiles apply to this host.
 2011-05-16 11:23:15, DEBUG   : Reading variables from profile base
 2011-05-16 11:23:15, DEBUG   : Reading variables from profile default
 2011-05-16 11:23:15, DEBUG   : Reading variables from profile ced
 2011-05-16 11:23:15, DEBUG   : Reading variables from host voldemort
 2011-05-16 11:23:15, DEBUG   : Uninstall entry 'CCleaner' matches string 'CCleaner'.
 2011-05-16 11:23:15, DEBUG   : Uninstall entry for CCleaner was found: test successful

3) ''global exit codes'' of the whole wpkg.js got bad, so the postinst
 WPKGClient script does not get executed (for example).

 2011-05-16 11:23:15, DEBUG   : Saving XML : C:\WINDOWS\system32\wpkg.xml
 2011-05-16 11:23:15, DEBUG   : Installation of references (chained) for 'CCleaner' (ccleaner) successfully finished.
 2011-05-16 11:23:15, INFO    : Package 'CCleaner' (ccleaner): Package and all chained packages installed successfully.
 2011-05-16 11:23:15, INFO    : Processing (upgrade) of CCleaner successful.
 2011-05-16 11:23:15, DEBUG   : Cleaning up temporary downloaded files
 2011-05-16 11:23:15, ERROR   : Message:      Autorizzazione negata|Description:  Autorizzazione negata|Error number: 800a0046|Stack:        undefined|Line:         undefined|
 2011-05-16 11:23:15, INFO    : User notification suppressed. Message: Qualcosa nell'aggiornamento del sistema è fallito.


This seems to me rather unoptimal:

 + if download fail, also package have to fail.

 + download step have to check if file exist, and if exist can ignore
   them or redowload; to prevent abuse, better if an hash (md5) are
   used.

 + global status i think have not to be influenced by the download
   status; i think that download failures have to be considered minor
   failures and lead to a positive global exit status.


Hope this help. Thanks.


PS: say me if i've to fire up these as bugs on the BTS, and if as a
 single bug or as multiple one.

-- 
dott. Marco Gaiarin				    GNUPG Key ID: 240A3D66
  Associazione ``La Nostra Famiglia''                http://www.sv.lnf.it/
  Polo FVG  -  Via della Bontà, 7 - 33078  -  San Vito al Tagliamento (PN)
  marco.gaiarin(at)sv.lnf.it	  tel +39-0434-842711  fax +39-0434-842797

		Dona il 5 PER MILLE a LA NOSTRA FAMIGLIA!
	   http://www.lanostrafamiglia.it/chi_siamo/5xmille.php
	(cf 00307430132, categoria ONLUS oppure RICERCA SANITARIA)