[wpkg-users] [Bug 243] Empty variable value causes crash

[Rainer Meier]

Hi Stefan,

> Find the package below.
> I am currently updating my packages to use inline expansion of package variables.

Sorry to say but this package specification at no means crashes my WPKG 1.2.1-RC22.

Can you send me a full debug log so I can see where it crashes for you?

My log prints the vars correctly too:

2011-10-15 22:45:39, DEBUG   : Variable PKG_NAME = WpkgClient
2011-10-15 22:45:39, DEBUG   : Variable PKG_VERSION = 1.3.14
2011-10-15 22:45:39, DEBUG   : Variable PKG_EXE_VERSION = 1.0.0.22
2011-10-15 22:45:39, DEBUG   : Variable PKG_SOURCE = %SOFTWARE%\WPKG\WPKG 
Client\WPKG Client|1.3.14-AMD64.msi
2011-10-15 22:45:39, DEBUG   : Variable PKG_DESTINATION = C:\Program Files\wpkg
2011-10-15 22:45:39, DEBUG   : Variable PKG_INSTALL_SWITCH = ALLUSERS=1 
SETTINGSFILE="%WPKG_ROOT%\settings.xml"
2011-10-15 22:45:39, DEBUG   : Variable PKG_REMOVE_SWITCH =
2011-10-15 22:45:39, DEBUG   : Variable MyVar =

Note: The "MyVar" line is coming from my profile where I've used the MyVar 
definition in profile specification.

br,
Rainer


> ---
> Stefan
>
>      <package id="WpkgClient"
>              name="WPKG Client"
>              revision="%PKG_VERSION%"
>              reboot="false"
>              priority="999">
>
>          <variable name="PKG_NAME"           value="WpkgClient" />
>          <variable name="PKG_VERSION"        value="1.3.14" />
>          <variable name="PKG_EXE_VERSION"    value="1.0.0.22" />
>          <variable name="PKG_SOURCE"         value="%SOFTWARE%\WPKG\WPKG Client\WPKG Client
> %PKG_VERSION%-%PROCESSOR_ARCHITECTURE%.msi"/>
>          <variable name="PKG_DESTINATION"    value="%ProgramFiles%\wpkg"/>
>          <variable name="PKG_INSTALL_SWITCH" value='ALLUSERS=1 SETTINGSFILE="%WPKG_ROOT%\settings.xml"'/>
>          <variable name="PKG_REMOVE_SWITCH"  value=""/>
>
>          <check type="uninstall" condition="versiongreaterorequal" path="WPKG"                           value="%PKG_VERSION%" />
>          <check type="file"      condition="versiongreaterorequal" path="%PKG_DESTINATION%\wpkginst.exe" value="%PKG_EXE_VERSION%" />
>
>          <install cmd='MsiExec.exe /passive /norestart /log "%TMP%\%PKG_NAME%.log" /i "%PKG_SOURCE%" %PKG_INSTALL_SWITCH%'>
>              <exit code="1641" />
>              <exit code="3010" reboot="false"/>
>          </install>
>
>          <upgrade include="install" />
>
>          <remove cmd='MsiExec.exe /passive /norestart /log "%TMP%\%PKG_NAME%.log" /x "%PKG_SOURCE%" %PKG_REMOVE_SWITCH%' />
>      </package>
>