[wpkg-users] [Bug 234] Additional command line parameters /noquiet /notify etc

[Rainer Meier]

Hi Malte,

On 30.08.2011 15:21, Malte Starostik wrote:
> Am Samstag, 27. August 2011, 00:48:20 schrieb bugzilla-
> daemon at bugzilla.wpkg.org:
>> MOD: Updated log file handling. Now there is no intermediate local log file
>>       created any more. Instead a log is kept in memory as long as the log
>> file is not initialized. If anything goes wrong WPKG still tries to flush
>> the logs at least to a log file in %TEMP%.
>>       This potentially increases efficiency and execution speed slightly.
>
> This unfortunately causes a line like this to appear for every run, i.e.
> whenever a client starts up:
>
> 2011-08-30 15:10:48, DEBUG   : WPKG 1.2.1-RC10 starting...
>
> due to the logLevelDefault of 0xff.  We're using [HOSTNAME]-[YYYY][MM][DD][hh]
> [mm][ss].wpkg.log as logfilePattern, so this causes an unwanted file to be
> created every time and fills up our reporting tool.  If this is intended
> behaviour, I'll have to work around this.  Otherwise, well, maybe the log
> buffer needs to be an array of some object that includes the entry's level for
> later filtering.

This is correct. But it's not due to logLevelDefault of 0xff. It's basically due 
to the fact that I've changed the initial logLevelValue to 0xFF instead of 0x03.

I've reverted this now and I did some re-arrangement to print the WPKG starting 
message just after initialization (after reading config.xml and parsing command 
line parameters).

The issue here is that during initialization WPKG does not know which log level 
is configured. So it has to start with a certain log level.

I agree that it might be an issue since WPKG would not write any log file before 
if it does not perform any change and log level is set to something lower than 
debug.

The solution implemented in RC11 shall also not create any log file if 
everything goes OK.

br,
Rainer