[wpkg-users] [Bug 271] New: downloader.cmd too strict with MD5 pattern matching, causes false negative

[bugzilla-daemon at bugzilla.wpkg.org]

http://bugzilla.wpkg.org/show_bug.cgi?id=271

           Summary: downloader.cmd too strict with MD5 pattern matching,
                    causes false negative
           Product: WPKG
           Version: other
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: normal
          Priority: P2
         Component: config files
        AssignedTo: mangoo at wpkg.org
        ReportedBy: 39tk3s7u3y at snkmail.com
         QAContact: wpkg-users at lists.wpkg.org


Created attachment 237
  --> http://bugzilla.wpkg.org/attachment.cgi?id=237
Log showing default output of `pc-tools.net' md5sums tool

Downloader.cmd can reject a file that has correct MD5 if the checksum doesn't
start the line.

I use the md5sums tool from http://www.pc-tools.net/win32/md5sums/ (currently
version 1.2) and the default output puts the generated checksum at the end of
the line (see attached).  However, downloader.cmd (line ~337) uses 'findstr /B'
to restrict searching for the checksum at the start of the line.

This particular md5 tool does support a command-line option to mimic Unix
behavior and put the checksum at the start, but I propose removing the '/B'
option to provide better drop-in support for other MD5 tools that may also have
a default format different from Unix.

-- 
Configure bugmail: http://bugzilla.wpkg.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.