[wpkg-users] [Bug 271] downloader.cmd too strict with MD5 pattern matching, causes false negative

[bugzilla-daemon at bugzilla.wpkg.org]

http://bugzilla.wpkg.org/show_bug.cgi?id=271

Rainer Meier <r.meier at wpkg.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |r.meier at wpkg.org
         Resolution|                            |FIXED

--- Comment #1 from Rainer Meier <r.meier at wpkg.org>  ---
Although I do not fully agree that we should support any non-standard output I
did relax the checks to allow the checksum appearing anywhere in the checksum
tool output. This applies to MD5 as well as SHA1.

There is however a small risk that the checksum string appears somewhere else
in the output and therefore the checksum would be accepted even if the tool
prints a different one. However this is very unlikely. That's why I've accepted
your change request. We will revert the changes if somebody reports invalid
matches in the future.


MOD: Relaxed MD5/SHA1 checks to allow checksums appearing anywhere in the
     output of the MD5/SH1 checksum tool. This might be required for some tools
     printing checksums at the end of the line instead of standard unix-like
     output with the checksum at the beginning of the line.
     This change introduces a small risk of overmatching if the checksum string
     appears somewhere else on the output as downloader.cmd will just check
     that the required checksum appears anywhere in the checksum tool output.
     Fixes Bug 271. Thanks to Neil for reporting.


<http://wpkg.svn.sourceforge.net/viewvc/wpkg/wpkg/stable/src/main/resources/wpkg/tools/downloader/>


br,
Rainer

-- 
Configure bugmail: http://bugzilla.wpkg.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.