[wpkg-users] Upgrade Skips Checks

[Matthew Bowman]

On 2/21/12 12:55 PM, Paul McGrath wrote:
> Matthew,
>   I believe this is more a problem with your package xml than WPKG.  I've had this happen and it wasn't a wpkg.js issue.  
> Can you email your package xml for us to look at.  Also your event log so we can see that it says 'success' as I suspect it is still trying to upgrade each time as it hasn't succeeded.
> Thanks
> Paul
>
> -----Original Message-----
> From: wpkg-users-bounces at lists.wpkg.org [mailto:wpkg-users-bounces at lists.wpkg.org] On Behalf Of Matthew Bowman
> Sent: 21 February 2012 10:51
> To: wpkg-users at lists.wpkg.org
> Subject: [wpkg-users] Upgrade Skips Checks
>
> I've recently found myself in an odd situation. I recently upgraded a
> package that had an exit code of -3 (Install Shield - missing info in
> setup.iss file). This was not listed in the package.xml as success so
> therefore wpkg was not recording the package as installed (it retained
> the old version). However the package did install correctly. Now when my
> clients boot (I'm using Wpkg-GP), they upgrade the package again even
> though the check passes and wpkg should simply mark the package as
> installed.
>
> Conclusion: I believe wpkg.js does not execute the check before
> attempting an upgrade
>
> I believe if a package is going to be upgraded, the the checks
> associated with that specific revision of the package should be ran just
> like if that package was going to be installed (not upgraded). If the
> checks pass, simply mark the package as installed/upgraded and move on.
> This would prevent a "double upgrade" from happening which is what I am
> experiencing.
>
> Note: I upgraded to the latest wpkg.js 1.3.0 to see if this still
> happens and it does.
>
> Just wanted to post my findings / thoughts regarding this.
> --mgbowman
> -------------------------------------------------------------------------
> wpkg-users mailing list archives >> http://lists.wpkg.org/pipermail/wpkg-users/
> _______________________________________________
> wpkg-users mailing list
> wpkg-users at lists.wpkg.org
> http://lists.wpkg.org/mailman/listinfo/wpkg-users
> -------------------------------------------------------------------------
> wpkg-users mailing list archives >> http://lists.wpkg.org/pipermail/wpkg-users/
> _______________________________________________
> wpkg-users mailing list
> wpkg-users at lists.wpkg.org
> http://lists.wpkg.org/mailman/listinfo/wpkg-users
Paul,

I originally thought the same thing, but running wpkg.js from the
command line with /debug is how I discovered the -3 exit code. After
adding <exit code="-3"> in <upgrade> ... </upgrade>, the <check.../> is
executed, it succeeds, and the upgraded revision is stored in the local
wpkg.xml db. The double upgrade/re-install only happens at the first
reboot - subsequent reboots the package is verified as installed. This
is why I think the <check../> stanzas only happen pre and post install
but only post upgrade. I think it should also be pre upgrade.