[sheepdog] [sheepdog/sheepdog] c4e320: shared lib: drop unnecessary return value check

Vasiliy Tolstov v.tolstov at selfip.ru
Tue Aug 11 08:48:28 CEST 2015

2015-08-11 9:19 GMT+03:00 Yu Yang <yuyanggg at gmail.com>:
> Hi, Hitoshi,
> I am sorry to say that those patches may not be merged directly.  It may not work correctly.
> I check the patch here(c4e320b965fa47f74bbf0461e8c0043afef3d807) which is different from the original patch I submit in sheepdog-ng,
> I don't know why but I'm sure it cannot work as expect and import bugs. However , this is just one example and I didn't check others.
> And also as there is a bit different between sheepdog and sheepdog-ng, if those patches token from sheepdog-ng would be merged into sheepdog,  some work need to be done and the code need be reviewed.

Sorry, but i don't understand how this
c250eee4e86df992f33ec625dfaa7dbf48c9d5b1 goes to sheepdog as
c4e320b965fa47f74bbf0461e8c0043afef3d807 can bring bugs. May be i miss
something, but sd_run_sdreq returns already req->ret, so returned
values means request status.

Vasiliy Tolstov,
e-mail: v.tolstov at selfip.ru

More information about the sheepdog mailing list