[sheepdog] [sheepdog/sheepdog] c4e320: shared lib: drop unnecessary return value check

Yu Yang yuyanggg at gmail.com
Tue Aug 11 09:24:45 CEST 2015

Hi,  Vasiliy,
For the last line of function sd_vdi_rollback(), it always returns success although do_vdi_create() failed.
In this case, we need return error carried by ret.


> -----Original Message-----
> From: vase at selfip.ru [mailto:vase at selfip.ru] On Behalf Of Vasiliy Tolstov
> Sent: Tuesday, August 11, 2015 2:48 PM
> To: Yu Yang
> Cc: Hitoshi Mitake; sheepdog at lists.wpkg.org
> Subject: Re: [sheepdog] [sheepdog/sheepdog] c4e320: shared lib: drop
> unnecessary return value check
> 2015-08-11 9:19 GMT+03:00 Yu Yang <yuyanggg at gmail.com>:
> > Hi, Hitoshi,
> > I am sorry to say that those patches may not be merged directly.  It may not
> work correctly.
> >
> > I check the patch here(c4e320b965fa47f74bbf0461e8c0043afef3d807) which is
> different from the original patch I submit in sheepdog-ng,
> > I don't know why but I'm sure it cannot work as expect and import bugs.
> However , this is just one example and I didn't check others.
> >
> > And also as there is a bit different between sheepdog and sheepdog-ng, if
> those patches token from sheepdog-ng would be merged into sheepdog,  some
> work need to be done and the code need be reviewed.
> >
> Sorry, but i don't understand how this
> c250eee4e86df992f33ec625dfaa7dbf48c9d5b1 goes to sheepdog as
> c4e320b965fa47f74bbf0461e8c0043afef3d807 can bring bugs. May be i miss
> something, but sd_run_sdreq returns already req->ret, so returned
> values means request status.
> --
> Vasiliy Tolstov,
> e-mail: v.tolstov at selfip.ru

More information about the sheepdog mailing list